Closed Gerry546 closed 3 months ago
I had the same issue: https://github.com/OSSystems/meta-browser/issues/785
I'm on kirkstone, and using the kirkstone/rust-1.70 branch of meta-lts-mixins gave me a working build.
Seems you need rust with profiler support enabled as well. The recent rust recipes in oe-core and meta-lts-mixins disable the profiler: https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7
The kirkstone/rust-1.70 (and kirkstone/rust-1.68) branches still have the profiler enabled.
You are correct that this dependency is apparently needed which is indeed a problem. However, having enabled it again I bump into the next problem:
[4560/63971] python3 ../../third_party/catapult/tracing/bin/generate_about_tracing_contents --outdir gen/content/browser/tracing FAILED: gen/content/browser/tracing/about_tracing.js gen/content/browser/tracing/about_tracing.html python3 ../../third_party/catapult/tracing/bin/generate_about_tracing_contents --outdir gen/content/browser/tracing /home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/html_generation_controller.py:21: SyntaxWarning: invalid escape sequence '\(' if re.search('url\(.+\)', contents): /home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/style_sheet.py:63: SyntaxWarning: invalid escape sequence '\(' return re.sub('url\((?P"|\'|)(?P[^"\'()]*)(?P=quote)\)', /home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/style_sheet.py:75: SyntaxWarning: invalid escape sequence '\(' 'url\((?:["|\']?)([^"\'()]*)(?:["|\']?)\)', /home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/js_utils.py:7: SyntaxWarning: invalid escape sequence '\/' return js.replace('', '<\/script>') /home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/parse_html_deps.py:296: SyntaxWarning: invalid escape sequence '\/' raise Exception('Escape script tags with <\/script>') Traceback (most recent call last): File "/home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/html_module.py", line 28, in Parse parser_results = parse_html_deps.HTMLModuleParser().Parse(self.contents) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/parse_html_deps.py", line 298, in Parse return HTMLModuleParserResults(html) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/parse_html_deps.py", line 164, in __init__ self._soup = bs4.BeautifulSoup(html, 'html5lib') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/third_party/beautifulsoup4-4.9.3/py3k/bs4/__init__.py", line 243, in __init__ raise FeatureNotFound( bs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: html5lib. Do you need to install a parser library?
I already stumbled across this myself at the end of last week but didn't have the time yet to take a closer look (and forgot to file an issue). Thanks for reporting, and also thanks to @bobolopolis for figuring out the cause! I'll think about how to best fix this, and will check the html5lib
issue afterwards.
Removing profiler_builtins
from this list fixes the error, although I'm not sure if we'll run into other errors later on in the build.
I'm now also getting the same warnings errors as @Gerry546. I suspect that this is due to master's update from Python 3.11 to 3.12. Chromium tracks this at https://issues.chromium.org/issues/40283283, which e.g. also mentions the SyntaxWarning
s. They should be fixed in m122, and I hope that the bs4
/html5lib
issue will also be gone in that version.
I'll re-visit this issue once the m122 update is ready, and hopefully we can just include the profiler_builtins
change mentioned above in the update PR and have the master build working again.
Hm, I just realized that the next update I'll do is m121, not m122. I'll see if it's feasible to backport the patches needed to fix the Python 3.12 issues.
@MaxIhlenfeldt have you considered sending the rust bbappends changes to oe-core / master and to the kirkstone mixing layer?
The profiler option was disabled in oe-core master to fix rust reproducibility issues but it is enabled in kirkstone branch and build works fine there.
We can check the bbappends changes and then send it oe-core, if everything works fine.
We can check the bbappends changes and then send it oe-core, if everything works fine.
I'd be very grateful if you could handle that!
Hm, I just realized that the next update I'll do is m121, not m122. I'll see if it's feasible to backport the patches needed to fix the Python 3.12 issues.
Quick update: backporting https://crrev.com/c/5092950 should fix the compilation with Python 3.12. I'll include it in the m121 update, which I'll upload soon.
How do you manage to apply this as a backport? I cannot seem to devtool modify
chromium-ozone-wayland without devtool throwing an error:
ERROR: ExecutionError('git submodule foreach --recursive "git tag -f devtool-base"', 128, '', "fatal: No url found for submodule path 'third_party/rust-src' in .gitmodules\n")
And I can't add this as a patch directly via a .bbappend
as these files are not in unpacked source.
@Gerry546 please see #791 for the WIP update to m121, which contains the backported patch.
Thanks. That works. :) Good to have something compile again
Hi,
I cannot seem to get this recipe to build with the new rust support I use all the default flags of the recipe and follow master on all dependend layers.
I would like to know what I can do in order to get chromium to work again. :-)
I have taken out the snippet of the
do_compile
output where it seems to break for some reason: