search

OSSystems / meta-browser

OpenEmbedded/Yocto BSP layer for Web Browsers
MIT License
181 stars 187 forks source link

chromium: Update to 122.0.6261.128 #803

Closed MaxIhlenfeldt closed 3 months ago

MaxIhlenfeldt commented 3 months ago

Fixes #795.

Release notes: https://chromereleases.googleblog.com/2024/02/stable-channel-update-for-desktop_20.html https://chromereleases.googleblog.com/2024/02/stable-channel-update-for-desktop_22.html https://chromereleases.googleblog.com/2024/02/stable-channel-update-for-desktop_27.html https://chromereleases.googleblog.com/2024/03/stable-channel-update-for-desktop.html https://chromereleases.googleblog.com/2024/03/stable-channel-update-for-desktop_12.html

Build and patch changes:

Drop six backported patches that are included upstream now.

Drop arm/0002-Fix-static_assert-failed-build-error-on-32-bit-ARM.patch as it was only needed to fix a build error with clang < 17, which we don't support any more.

Rebase remaining patches and renumber remaining ARM patches.

License changes:

Added licenses:

Removed licenses:

Updated licenses:

Test-built (big thanks to @rjanani-p):

Signed-off-by: Max Ihlenfeldt max@igalia.com

MaxIhlenfeldt commented 3 months ago

Turns out only around 70 licenses are now included due to upstream changes to the license script. The previous and much higher number I reported was due to me messing up the script so that non-shipped licenses were included as well :sweat_smile: Fortunately, these added licenses are all located under easily recognizable paths, so I think I managed to spot all licenses that were actually new.

@rjanani-p as always, testing would be greatly appreciated!

MaxIhlenfeldt commented 3 months ago

Also, I can't remember how long it's been since I was able to upload a PR without adding any new patches... not having to support clang < 17 is great!

rjanani-p commented 3 months ago

Turns out only around 70 licenses are now included due to upstream changes to the license script. The previous and much higher number I reported was due to me messing up the script so that non-shipped licenses were included as well šŸ˜… Fortunately, these added licenses are all located under easily recognizable paths, so I think I managed to spot all licenses that were actually new.

@rjanani-p as always, testing would be greatly appreciated!

@MaxIhlenfeldt ,I have completed the testing for Poky master with latest changes, sharing the results for reference:

1.For chromium-x11 & qemux86-64 target: compiled successfully without build issues, able to check chromium version using qemux86-64 emulator

2.For chromium-x11 & qemuarm target: compiled successfully without build issues, to check chromium version using qemuarm emulator unable to check it due to curser / mouse is not working properly while operating with chromium browser

3.For chromium-x11 & qemuarm64 target: compiled successfully without build issues, able to check chromium version using qemuarm64 emulator

4.For chromium-ozone-wayland & qemux86-64 target: compiled successfully without build issues, able to check chromium version using qemux86-64 emulator

  1. For chromium-ozone-wayland & raspberrypi4-64 target: compiled successfully without build issues, didn't check with hardware due to hardware unavailability.

Next, I will start testing for poky nanbield.

rjanani-p commented 3 months ago

Turns out only around 70 licenses are now included due to upstream changes to the license script. The previous and much higher number I reported was due to me messing up the script so that non-shipped licenses were included as well šŸ˜… Fortunately, these added licenses are all located under easily recognizable paths, so I think I managed to spot all licenses that were actually new.

@rjanani-p as always, testing would be greatly appreciated!

@MaxIhlenfeldt , getting compilation issue for poky nanbied & target qemux86-64 for chromium-x11 recipe

[268/58024] python3 ../../third_party/node/node.py ../../third_party/devtools-frontend/src/front_end/core/i18n/collect-ui-strings.js --input-directories ../../third_party/devtools-frontend/src/front_end --output-directory gen/third_party/devtools-frontend/src/front_end/core/i18n/locales/generated FAILED: gen/third_party/devtools-frontend/src/front_end/core/i18n/locales/generated/en-US.json python3 ../../third_party/node/node.py ../../third_party/devtools-frontend/src/front_end/core/i18n/collect-ui-strings.js --input-directories ../../third_party/devtools-frontend/src/front_end --output-directory gen/third_party/devtools-frontend/src/front_end/core/i18n/locales/generated Traceback (most recent call last): File "/build_chrom_122_poky_nanbield/tmp/work/core2-64-poky-linux/chromium-x11/122.0.6261.128/chromium-122.0.6261.128/out/Release/../../third_party/node/node.py", line 39, in RunNode(sys.argv[1:]) File "/build_chrom_122_poky_nanbield/tmp/work/core2-64-poky-linux/chromium-x11/122.0.6261.128/chromium-122.0.6261.128/out/Release/../../third_party/node/node.py", line 34, in RunNode raise RuntimeError('Command \'%s\' failed\n%s' % (' '.join(cmd), err)) RuntimeError: Command '/build_chrom_122_poky_nanbield/tmp/work/core2-64-poky-linux/chromium-x11/122.0.6261.128/chromium-122.0.6261.128/out/Release/../../third_party/node/linux/node-linux-x64/bin/node ../../third_party/devtools-frontend/src/front_end/core/i18n/collect-ui-strings.js --input-directories ../../third_party/devtools-frontend/src/front_end --output-directory gen/third_party/devtools-frontend/src/front_end/core/i18n/locales/generated' failed /build_chrom_122_poky_nanbield/tmp/work/core2-64-poky-linux/chromium-x11/122.0.6261.128/chromium-122.0.6261.128/third_party/devtools-frontend/src/node_modules/glob/common.js:19 return a.localeCompare(b, 'en') ^
RangeError: Internal error. Icu error.
at String.localeCompare ()

Error is expected for poky nanbield ?

MaxIhlenfeldt commented 3 months ago

Error is expected for poky nanbield ?

No, and I don't see it in my local nanbield build for qemux86-64. What's the output when you run /build_chrom_122_poky_nanbield/tmp/work/core2-64-poky-linux/chromium-x11/122.0.6261.128/chromium-122.0.6261.128/third_party/node/linux/node-linux-x64/bin/node --version?

rjanani-p commented 3 months ago

Error is expected for poky nanbield ?

No, and I don't see it in my local nanbield build for qemux86-64. What's the output when you run /build_chrom_122_poky_nanbield/tmp/work/core2-64-poky-linux/chromium-x11/122.0.6261.128/chromium-122.0.6261.128/third_party/node/linux/node-linux-x64/bin/node --version?

/chromium_ver_122_builds/builds_chromium/build_chrom_122_poky_nanbield/tmp/work/core2-64-poky-linux/chromium-x11/122.0.6261.128/chromium-122.0.6261.128/third_party/node/linux/node-linux-x64/bin/node --version v20.8.1

getting version as v20.8.1, for 3 targets (qemux86-64, qemuarm, qemuarm64) getting same build issue

MaxIhlenfeldt commented 3 months ago

Hm, that's the same version I see. I'm not sure what could be causing this, do you maybe have a repo manifest you can share with me, together with all your local .conf files, so I can replicate your setup as close as possible?

rjanani-p commented 3 months ago

@MaxIhlenfeldt ,I have cross checked the Poky nanbield with latest changes and clean build, didn't face any compilation issues and completed the testing below configuration. Here I am sharing the results for reference:

1.For chromium-x11 & qemux86-64 target: compiled successfully without build issues, able to check chromium version using qemux86-64 emulator

2.For chromium-x11 & qemuarm target: compiled successfully without build issues, to check chromium version using qemuarm emulator unable to check it due to curser / mouse is not working properly while operating with chromium browser

3.For chromium-x11 & qemuarm64 target: compiled successfully without build issues, able to check chromium version using qemuarm64 emulator

  1. For chromium-x11 & raspberrypi4-64 target: compiled successfully without build issues, didn't check with hardware due to hardware unavailability.

5.For chromium-ozone-wayland & qemux86-64 target: compiled successfully without build issues, able to check chromium version using qemux86-64 emulator

MaxIhlenfeldt commented 3 months ago

@rjanani-p iiuc this means there are no issues and we can go ahead and merge this?

rjanani-p commented 3 months ago

@rjanani-p iiuc this means there are no issues and we can go ahead and merge this?

yes @MaxIhlenfeldt we can merge, during my testing didn't face issues.

MaxIhlenfeldt commented 3 months ago

Updated the Test-built section in the commit message and PR description, we're good to go!