search

OSSystems / meta-browser

OpenEmbedded/Yocto BSP layer for Web Browsers
MIT License
184 stars 191 forks source link

chromium: Backport missing dependency in NewTabPage #815

Closed dsemkowicz-tt closed 4 months ago

dsemkowicz-tt commented 4 months ago

Dependency is missing in NewTabPage module. This can cause random build errors. Error occurrence depends on the order in which packages were build. It seems to occur more frequently with lower BB_NUMBER_THREADS values.

Build failed in my case usually with following error:

Error: Could not load gen/ui/webui/resources/tsc/cr_components/history_clusters/history_clusters_shared_style.css.js (imported by gen/chrome/browser/resources/new_tab_page/tsc/modules/history_clusters/suggest_tile.js): ENOENT: no such file or directory, open 'gen/ui/webui/resources/tsc/cr_components/history_clusters/history_clusters_shared_style.css.js'

This issue most likely occurs also on master (Chromium 122 at the moment of writing), because fix was merged in version 125. I experienced this problem only on kirkstone branch and didn't test the master. If you think this fix is also beneficial on master, I can do a rebase on 122 and push the second MR.

MaxIhlenfeldt commented 4 months ago

This issue most likely occurs also on master (Chromium 122 at the moment of writing), because fix was merged in version 125. I experienced this problem only on kirkstone branch and didn't test the master. If you think this fix is also beneficial on master, I can do a rebase on 122 and push the second MR.

If that's ok for you, I can create a PR for master once #806 is merged.

dsemkowicz-tt commented 4 months ago

If that's ok for you, I can create a PR for master once #806 is merged.

That's fine for me. Thank you.