search

OSTrails / FAIR_assessment_output_specification

Repository to track the requirements and specifications of FAIR assessment reports
Apache License 2.0
3 stars 1 forks source link

Reuse dqv:Metric instead of TestSpecification or Test #13

Open huberrob opened 1 day ago

huberrob commented 1 day ago

At https://ostrails.github.io/FAIR_assessment_output_specification/release/0.0.1 there is a class called https://w3id.org/ftr#TestSpecification which is not part of the image at FAIRTestResult_diagram_v4.drawio.png . But there I see a ftr:Test class.

I assume they are the same thing? If 'Test' is the latest name, I would recommend to rename it back to TestSpecification or e.g. to Metric because 'Test' is quite generic and could also mean an activity (test activity)

To make the model compatible with DQV I would propose to define it as a subclass of dqv:Metric or just reuse dqv:Metric in the model?

markwilkinson commented 1 day ago

Tests and Metrics are different things in the OSTrails terminology and component model...

dgarijo commented 1 day ago

I need to make sure everything is aligned to the latest discussion (my bad). Thanks for opening the issue, Robert!

El mié., 18 sept. 2024 12:49 p. m., Mark Wilkinson @.***> escribió:

Tests and Metrics are different things in the OSTrails terminology and component model...

— Reply to this email directly, view it on GitHub https://github.com/OSTrails/FAIR_assessment_output_specification/issues/13#issuecomment-2358142312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTIGXEWSTPL27OBYGHFJ3ZXFLFNAVCNFSM6AAAAABONMTI5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJYGE2DEMZRGI . You are receiving this because you are subscribed to this thread.Message ID: <OSTrails/FAIR_assessment_output_specification/issues/13/2358142312@ github.com>

huberrob commented 1 day ago

Yes that would be good, because at the README I just discovered the sentence "Test: A test (service) implementing a dqv:Metric" so then it is rather a TestActivity? But it seems to be a dcat:DataService so it is the API/software etc which is performing the test?

If so I would propose to rename it to something like 'TestingAgent' which is a subclass of prov:SoftwareAgent in addition to dact:DataService

dgarijo commented 1 day ago

Hi Robert, invoking a testing service would be the activity. We align to a dcat:DataService since we reuse much of its metadata. Testing agent may be a little confusing, but I think having the entity inherit from SoftwareAgent makes sense to me.

El mié, 18 sept 2024 a las 15:10, huberrob @.***>) escribió:

Yes that would be good, because at the README I just discovered the sentence "Test: A test (service) implementing a dqv:Metric" so then it is rather a TestActivity? But it seems to be a dcat:DataService so it is the API/software etc which is performing the test?

If so I would propose to rename it to something like 'TestingAgent' which is a subclass of prov:SoftwareAgent in addition to dact:DataService

— Reply to this email directly, view it on GitHub https://github.com/OSTrails/FAIR_assessment_output_specification/issues/13#issuecomment-2358430562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTIGTUAU4KNQLTCV7JHX3ZXF3UFAVCNFSM6AAAAABONMTI5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJYGQZTANJWGI . You are receiving this because you commented.Message ID: @.*** .com>

huberrob commented 1 day ago

Ok, so maybe 'TestService' would be a better name for this? Just 'Test' is very generic and thus a bit confusing

dgarijo commented 1 day ago

Hmm, i do not disagree in principle, but the way I see it is more a test description, and "test" fits quite well. Let me update the spec next week and we can come back to the issue.