search

OSU-AIMS / light_painting

Demonstration project which traces a LED EEF through space for a long-exposure photo.
Apache License 2.0
0 stars 0 forks source link

Added a modification to t1_launch file and add serial_node.py file to… #12

Closed hadeelq1 closed 1 year ago

hadeelq1 commented 1 year ago

… scripts folder

acbuynak commented 1 year ago

@hadeelq1 I see you opened and closed this PR. Typically, I'd like to have someone review and test this code prior to merging into main. Is this code ready to review?

Thanks!

FYI @TobiasJMahan

acbuynak commented 1 year ago

Fixes #3

hadeelq1 commented 1 year ago

Hello Adam,

Sorry about merging it to the main. I am still learning to navigate GitHub. I did pull a request and then I hit to merge it by accident. I really want you to view it and I would really appreciate any feedback on it. Yes, this code is ready for review.

Sincerely, Hadeel Qadri

From: A. C. Buynak @.> Sent: Wednesday, June 7, 2023 5:02 PM To: OSU-AIMS/light_painting @.> Cc: Hadeel Qadri @.>; Assign @.> Subject: [EXTERNAL] Re: [OSU-AIMS/light_painting] Added a modification to t1_launch file and add serial_node.py file to… (PR #12)

This email originated from outside the Columbus State email system. Please exercise caution when clicking links or attachments within this email or responding to requests for personal data. Never act on gift card requests.

Assigned #12https://github.com/OSU-AIMS/light_painting/pull/12 to @hadeelq1https://github.com/hadeelq1.

— Reply to this email directly, view it on GitHubhttps://github.com/OSU-AIMS/light_painting/pull/12#event-9464257272, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4AVB67JWJIFXPHLRUBI4XLXKDT6DANCNFSM6AAAAAAY6MSTK4. You are receiving this because you were assigned.Message ID: @.***>

hadeelq1 commented 1 year ago

Thank you for reviewing it. I can terminate after 60 seconds or I can ask if the Arduino is plugged in and if it is yes than I will attempt to connect to it.

-- EDIT: Removed email chain quote reply.