search

OSU-CS361-W17 / group14_project1

0 stars 3 forks source link

Added player shooting to battleshipmodel #14

Closed millelog closed 7 years ago

millelog commented 7 years ago

Also added tests to the board and tests are 100% cover the coordinate class now. use this for references for tests but I have to go. there is one test in board that still isn't passing. email me if you need help.

reypocius commented 7 years ago

The tests look great! Though for the player shooting function we should also be checking against the coordinates where the player has already fired on. Maybe in the if statement on line 31 of BattleshipModel.java we could add another two &&'s that check spaces that are occupied by a miss.