OSU-CS361-W17 / group8_project1

0 stars 1 forks source link

JUnit Tests #1 #22

Closed jlioy closed 7 years ago

jlioy commented 7 years ago

Started adding somme JUnit tests some of the basic classes are 100% covered.

SilverMagnum commented 7 years ago

Alright, I reviewed your code. All the changes you made look good. I noticed you removed the floor part on an equation I was using, which I think is you confirming that the formula will behave as if it is flooring with the floor function. The point tests seem reasonable but for the ship test, I think it might be a good idea to add some bad input ship tests and show that it can recover. Perhaps recovery is too complicated for this sprint though so I'll let you decide what is best.