OSU-MC / MyClassroom

📋Open-Source Classroom Polling Application
https://osu-mc.github.io
GNU General Public License v3.0
4 stars 2 forks source link

Page Modal Component #215

Closed Durbin-Elijah closed 4 months ago

Durbin-Elijah commented 4 months ago

Screenshots

image

Description

Didn't get to much styling in this PR, but lots of changes to how new pages can be loaded by adding a component that is a button that opens a new page within a modal. I would like to get this functionality approved and merged with other changes before I get back to styling.

Additional Information

Works as expected on my end but it should be tested by others to make sure everything works the same on other machines.

Also, feel free to tell me if this was a bad solution and there was a much better way, that's my bad for not going over my plans in detail.

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

*I don't think we have tests for frontend things, and I'm not sure what automated tests could do for this feature. Feel free to comment any concerns about this.

nilsstreedain commented 4 months ago

Branch was created from main not dev and is missing changes. This also introduces a history loop (i.e. dev to main to dev. Please move changes to a new branch created from dev and resubmit.