OSURoboticsClub / aerial_control

Aerial vehicle firmware
MIT License
2 stars 4 forks source link

Implement parameter access/storage #33

Closed kylc closed 8 years ago

kylc commented 9 years ago

Two options I'm thinking about right now:

  1. Have a big "ParameterStore" object that individual components can use as a dictionary-like interface to look up params. For example, store.lookup("ATT_VEL_P"). Disadvantage is string lookups and more implicit, advantage is less parameter passing.
  2. Pass individual parameters around all over the place. For example, send Parameter& p, Parameter& i, Parameter& d to a PID controller. Disadvantage is a LOT of passing parameter objects around. Advantage is that it's explicit.
kylc commented 9 years ago

Leaning towards option 1, perhaps with enum keys rather than strings. Implementation of option 1 on enhancement/33_parameters.

kylc commented 8 years ago

This is moving forward but needs testing before I spend a lot of time ripping out code. Waiting on hardware.

kylc commented 8 years ago

Closing. The rest of the work is going into #54.