OSVR / OSVR-Core

The core libraries, applications, and plugins of the OSVR software platform.
Apache License 2.0
329 stars 124 forks source link

OpenGLSample is out of alignment. Possible DisplayConfig bug? #472

Open JeroMiya opened 8 years ago

JeroMiya commented 8 years ago

User reported a viewport alignment issue on Linux with the OpenGLSample in OSVR-Core. They are using the osvr_server_config.HDK20ExtendedLandscape.sample.json configuration with an HDK2.

"The left eye view is shifted too far to the left, and I can see a portion of the right view through the right edge of the left lens. The right eye seems fine."

I suspect a bug in the DisplayConfig API.

russell-taylor commented 8 years ago

Their primary display might not be 1280x1024 resolution, so the config file may be putting the window in the wrong place. Unfortunately, the display location depends on the relative placement of the HMD in the virtual desktop, which depends on the original display resolution if it is located to the right of the main display.

technobill commented 8 years ago

I'm the user that asked about this. The HMD is my only display on that system. I can mostly "fix" the alignment by subtracting 64 (experimentally determined) from the right eye's viewport.left in osvr::client::computeViewport(). I still see a bit of the right view in the left eye. Only ClientKit is affected, the RenderManager samples work fine, no fix required. Also, if I run with the default empty config file, the alignment is good, but it reports the display as 1920x1080.