search

OSVR / OSVR-Core

The core libraries, applications, and plugins of the OSVR software platform.
Apache License 2.0
330 stars 124 forks source link

Cleanup #586

Closed rpavlik closed 6 years ago

rpavlik commented 6 years ago

Small cleanup of things seen when building on Linux with Clang 6.0. (Plus one or two things that I just noticed could be improved as drive-by fixes)

I should try this on Windows before merging it, in theory.

godbyk commented 6 years ago

= default could be declared in the headers unless you want to hide the implementation.

Otherwise, it looks good to me on first read through. I haven't actually tested it.

rpavlik commented 6 years ago

Have to hide the implementation to ensure the destruction happens within a dll, not in its consumer - for the same reason that the constructor and factory func are hidden. Mainly a very sneaky windows bug.

rpavlik commented 6 years ago

OK, this has been rebased, so travis should work now. Still haven't tried Windows (and AppVeyor isn't set up right)

rpavlik commented 6 years ago

OK, doesn't appear to break Windows, so merging.