OSVR / OSVR-Unity

Package for authoring OSVR experiences with Unity.
Apache License 2.0
99 stars 38 forks source link

Handle `size_t` length arguments properly in ClientKit wrapper. #12

Closed rpavlik closed 9 years ago

rpavlik commented 9 years ago

Lines I'm talking about:

The corresponding C methods those invoke are here: https://github.com/OSVR/OSVR-Core/blob/master/inc/osvr/ClientKit/ParametersC.h

Note that those are actually size_t which is platform dependent, and which I think we can assume is the same as uint_ptr_t. size_t is the idiomatic type to use there from a C and C++ perspective, so if reasonable I'd like to leave those signatures alone. However, it poses an issue to the .NET bindings. It looks like there's a way to handle it properly. If it turns out to be unfeasible, we can change those to uint32_t if needed, since that should be a big enough type, but if a solution isn't too hard that's just in the .NET stuff I think that's probably preferred.

Here are the links I've collected related to this issue.

rpavlik commented 9 years ago

OK, this has been done in the new separated-out https://github.com/OSVR/Managed-OSVR repo, so once we port to there, it will just be some build system changes.

rpavlik commented 9 years ago

Going to consider this closed, since other issues refer to the build system changes.