search

OSVR / OSVR-Unity

Package for authoring OSVR experiences with Unity.
Apache License 2.0
98 stars 38 forks source link

Render manager singleton #163

Closed DuFF14 closed 8 years ago

DuFF14 commented 8 years ago

Makes OsvrRenderManager.cs a persistent singleton, which fixes the scene switching issues described in https://github.com/OSVR/OSVR-Unity/issues/162

Please test and provide feedback if you've been dealing with this issue. A preview .unitypackage is attached. OSVR-Unityv0.6.8.3-preview.unitypackage.zip

@demonixis @JacBellu

RedIronLabs commented 8 years ago

The good news: I'm not seeing the crashes.

The bad news: It periodically loses connection to the HMD on a scene reload, and because its in direct mode, the HMD just stops and displays a black screen.

I'll try and create a smaller second project for replicating that and submit it as a new issue (hard crashes in direct-mode on scene reloads seem fixed to me).

DuFF14 commented 8 years ago

@RedIronLabs thanks for testing. Check out this issue before opening a new one, in case it's the same symptoms: https://github.com/OSVR/OSVR-Unity/issues/127 I'm not able to reproduce crashes between scene reloads, so any information about your setup is helpful.

RedIronLabs commented 8 years ago

@DuFF14 Thanks for checking back with me,

Upon closer testing - it is not crashing and the HMD didn't stop. For some reason, Direct Mode is ignoring all the lighting in the scene and showing a black screen when in deferred. As soon as I mark it as Forward render, it shows the the scene, just really ugly :) Anyway, no crashing, I've done hundreds and hundreds of scene reloads

Cheers