OSVR / OSVR-Unity

Package for authoring OSVR experiences with Unity.
Apache License 2.0
98 stars 38 forks source link

Windows 10 Universal Platform build compatibility #232

Open demonixis opened 7 years ago

demonixis commented 7 years ago

Hi,

OSVR is not yet compatible with the Windows 10 Universal Platform. This platform has a new API with some missing functions, such as DLLImport. It's a real problem for a lot of SDK so we just have to patch sources with

#if !UNITY_WSA
[DLLImport(SomFunction)]
public extern static SomeFunction();
#else
public static SomeFunction() { }
#endif

[I already patched and submited a pull request] on the ’Managed-OSVR’ repository, my work allows you to generate a placeholder DLL (which must be used in Unity by example).

For my game which is already compatible with the Vive, Rift and of course OSVR, I had to patch all the OSVR SDK. Today I want to know if you're interested by this work. It changes some files, but it changes no behaviours, or anything.

The first step could be to merge my work, but a second step could be to move all ’DLLImport’ into separate files to have the native call and the SDK separated.

If you're OK with that, I can update my repository last week.

DuFF14 commented 7 years ago

@demonixis Sounds like a good change. Are you going to open a PR for this repo? How would I be able to test this? @JeroMiya should probably review the Managed-OSVR changes.

demonixis commented 7 years ago

I can create a pull request last week, I'm just back from vacancy and I've an important update to push quicky. I saw you're working on two branches (skeleton & android), do you want to merge these branches before my PR?

DuFF14 commented 6 years ago

go ahead and create a PR, I don't know if the other PRs will be merged this week or not.

demonixis commented 6 years ago

Great, I prepare the PR today! The second step if you're OK this with could be to centralize all DLLImport into a native or a set of natives file(s). This way we can use an uniq #if !UNITY_WSA define. The same idea could be nice for Managed-OSVR.

I read that the Windows Mixed Reality HMD will be useable from the Unity Editor! I think that we can create a driver for OSVR as well. This could be awesome because for now, those HMD are limited to the Windows Store.

demonixis commented 6 years ago

I just opened #233 with all changes ;)