OSVR / OSVR-win-installer

Basic windows installer
Apache License 2.0
5 stars 10 forks source link

Indicating runtime location on the system #15

Open rpavlik opened 8 years ago

rpavlik commented 8 years ago

cc @JeroMiya

Would be good to indicate runtime locations on the system. The simple way is to set an environment variable, to say "I am the OSVR install.". The more complete way would be to essentially add itself to a list of OSVR installs, to permit choosing between installs. (These are not mutually exclusive: a new install might add itself to the list of installs, and may set itself as a system-wide default)

I've seen two models for this:

Obviously, if we decide that keeping track of multiple locations of OSVR on the system is something we want to do, you know which general technique has my vote ;)

JeroMiya commented 8 years ago

cc: https://github.com/OSVR/OSVR-Core/pull/380

The current implementation uses the OSVR_SERVER_ROOT environment variable. If the installer set that environment variable (preferably user level environment variable) on Windows, then the auto-launch functionality would work.

gfrolov commented 8 years ago

First step with indicating runtime location is done - https://github.com/OSVR/OSVR-win-installer/commit/40257ee8c3ee7965a2714220e66199bd4913203b It adds (and removes on uninstall) user lever environment variable - OSVR_SERVER_ROOT which points to bin folder with all "exes", when you install runtime or sdk. @rpavlik , not sure if I understood completely the adding to a list of OSVR installs? Do you mean maintaining an environment variable like "OSVR_ROOT" and append install locations when you install SDK and Runtime?

gfrolov commented 8 years ago

@rpavlik, @JeroMiya Which direction do we want to go here. Appending multiple locations to OSVR_SERVER_ROOT will break things for OSVR-Config and auto launch. I recently fixed issue #17 where it appended multiple values and I think it was causing some problems. We can of course setup a new variable OSVR_INSTALL_LOCATIONS, if needed?