search

OSVR / SteamVR-OSVR

An OSVR plugin for SteamVR, providing SteamVR support for OSVR HMDs.
Apache License 2.0
138 stars 57 forks source link

Offset center of projection #93

Closed simlrh closed 3 years ago

simlrh commented 8 years ago

Applies the appropriate center of projection if it isn't dead center.

It seems like this should be done with Prop_LensCenterLeftU_Float etc, but those properties appear never to be requested by OpenVR.

russell-taylor commented 8 years ago

The COP settings in RenderManager currently depend on the scale settings (called D), as described in https://github.com/sensics/OSVR-RenderManager/blob/master/osvr/RenderKit/DistortionParameters.h#L98

There is an issue to change this at https://github.com/sensics/OSVR-RenderManager/issues/227 that I think one of the Sensics engineers has on her plate.

russell-taylor commented 7 years ago

The COP is settings in RenderManager have been adjusted to apply the D scales to a symmetric distortion parameters, rather than having them changed in the config file, in RM commit fc38e9fd2bac7634f03eafe8cbd23c6015c51341 which will soon be a pull request. They will no longer depend on D values, but will still depend on overfill. This dependency is handled by RenderManager, but will need to be handled separately by any other code that wants to parse the RenderManager config and make its own matrices.