Handling of wave.do - Githubissues

riedel-ferringer commented 1 year ago

Don't execute wave.do if not in GUI mode (https://github.com/OSVVM/OSVVM-Scripts/issues/29)
Don't fail the simulation if wave.do throws errors (they are minor, usually because some signals for the waveform viewer could not be found (https://github.com/OSVVM/OSVVM-Scripts/issues/33)
On my setup, wave.do is sourced twice. I found the reason to be that path comparisons mismatch because the current directory is represented as '.' rather than the absolute path (https://github.com/OSVVM/OSVVM-Scripts/issues/34)

This Pull Request combines three findings regarding wave.do and is a suggestion for resolving the issue(s). However, I am not fully aware of some of the implications (esp. removing the ReducePath procedure).

JimLewis commented 1 year ago

Markus, I am not good enough at git to pull just the change for #33, so I will manually add that one.
I will also add a fix at the point where the paths are checked so wave.do is not done twice.

JimLewis commented 1 year ago

Please do your pull requests against the Dev branch rather than main. That way you will know about things I have already done - such as #29.

JimLewis commented 1 year ago

All of these are now fixed in dev. I did the file normalize where the paths are checked.

OSVVM / OSVVM-Scripts

Handling of wave.do #35