search

OSWeekends / batimagen

Un proyecto sobre metadatos del guild de ciberseguridad
GNU General Public License v3.0
12 stars 3 forks source link

CVE-2017-18214 High Severity Vulnerability detected by WhiteSource #24

Closed mend-bolt-for-github[bot] closed 5 years ago

mend-bolt-for-github[bot] commented 5 years ago

CVE-2017-18214 - High Severity Vulnerability

Vulnerable Library - moment-2.15.2.tgz

Parse, validate, manipulate, and display dates

path: /tmp/git/batimagen/node_modules/emailjs/node_modules/moment/package.json

Library home page: https://registry.npmjs.org/moment/-/moment-2.15.2.tgz

Dependency Hierarchy: - node-virustotal-2.4.2.tgz (Root Library) - emailjs-1.0.12.tgz - :x: **moment-2.15.2.tgz** (Vulnerable Library)

Vulnerability Details

The moment module before 2.19.3 for Node.js is prone to a regular expression denial of service via a crafted date string, a different vulnerability than CVE-2016-4055.

Publish Date: 2018-03-04

URL: CVE-2017-18214

CVSS 3 Score Details (7.5)

Base Score Metrics: - Exploitability Metrics: - Attack Vector: Network - Attack Complexity: Low - Privileges Required: None - User Interaction: None - Scope: Unchanged - Impact Metrics: - Confidentiality Impact: None - Integrity Impact: None - Availability Impact: High

For more information on CVSS3 Scores, click here.

Suggested Fix

Type: Change files

Origin: https://github.com/moment/moment/commit/69ed9d44957fa6ab12b73d2ae29d286a857b80eb

Release Date: 2017-11-29

Fix Resolution: Replace or update the following files: regex.js, moment-with-locales.js, moment.js

Step up your Open Source Security Game with WhiteSource here

ElenaMLopez commented 5 years ago

@UlisesGascon ... we got a porblem jejejej tenemos que ver esto

Kr0n0 commented 5 years ago

Cambiar los tres ficheros para evitar el ReDoS. Lo tienes en la misma descripción ;)

Kr0n0 commented 5 years ago

Yo no tengo registro en npm, pero supongo que vosotros si...

node-virustotal-2.4.2.tgz (Root Library) emailjs-1.0.12.tgz ❌ moment-2.15.2.tgz (Vulnerable Library)

emailjs va por la v2.2.0 y el paquete node-virustotal-2.4.2 hace mucho que no se actualiza.

Fix : https://github.com/moment/moment/commit/69ed9d44957fa6ab12b73d2ae29d286a857b80eb

¿Queréis avisar a NPM para que lo gestionen? https://www.npmjs.com/advisories/report?package=node-virustotal

Si no lo hago por mail, pero por el propio sistema es más rápido, creo.

UlisesGascon commented 5 years ago

Gracias por el análisis @Kr0n0! Creo que podríamos hacer un PR directamente para actualizar nosotros virus-total. Parece sencillo... te vienes arriba @ElenaMLopez ? Ref