search

OSeMOSYS / OSeMOSYS_GNU_MathProg

The GNU MathProg implementation of OSeMOSYS
Apache License 2.0
9 stars 15 forks source link

Double Negative for Storage Costs in Objective Equation #106

Open trevorb1 opened 2 weeks ago

trevorb1 commented 2 weeks ago

Hi! I have a question relating to how Storage Salvage Value is treated in the objective equation in OSeMOSYS_fast:

I think the actual calculation of discounting the salvage value is correct, but we are adding it to the cost (via the double negative) rather than subtracting it? Or I may just be interpreting something wrong?

https://github.com/OSeMOSYS/OSeMOSYS_GNU_MathProg/blob/95202686438c7e769fe220bc109a89e73f9f8667/src/osemosys_fast.txt#L336-L344

image

willu47 commented 2 weeks ago

Classic. That's a good catch....