search

OSeMOSYS / OSeMOSYS_GNU_MathProg

The GNU MathProg implementation of OSeMOSYS
Apache License 2.0
9 stars 15 forks source link

Corrected accounting for CapitalCostStorage in objective function #8

Closed ResearchAtPlay closed 5 years ago

ResearchAtPlay commented 5 years ago

In osemosys_short the capital cost of STORAGE was being double counted. The sum{s in STORAGE} was inside the sum{r in REGION, t in TECHNOLOGY, y in YEAR}. Therefore, the storage costs were multiplied by the number of regions times the number of technologies times the number of years.

In the corrected version the accounting for storage costs has been moved outside of the sum{r in REGION, t in TECHNOLOGY, y in YEAR} such that sum{r in REGION, s in STORAGE, y in YEAR} are added separately only once.

willu47 commented 5 years ago

Hi @ResearchAtPlay - many thanks for finding this error in the objective function. I'm going to run some tests to confirm the difference between the two formulations and get back to you.