search

OSeMOSYS / OSeMOSYS_Pyomo

The Pyomo implementation of OSeMOSYS
Apache License 2.0
15 stars 13 forks source link

Contribution to OSeMOSYS_pyomo #1

Open Mattia-Allione opened 4 years ago

Mattia-Allione commented 4 years ago

Hello, I am Mattia and I am currently working at my master thesis at 'Politecnico di Torino' using OSeMOSYS; so working with the pyomo code I noticed that in the TotalNewCapacity_2_rule is written: "if model.CapacityOfOneTechnologyUnit != 0:" instead of "if model.CapacityOfOneTechnologyUnit[r, t, y] != 0:". Moreover I have also written the storage equations, storage constraints and storage investments in pyomo environment, so attached to this issue there is also the script updated. Thanks for all your work developing the open source energy modelling system. Best regards; Mattia OSeMOSYS-Pyomo_2019_10_30.txt

tniet commented 4 years ago

Hi Mattia - Thanks for putting some work into the Pyomo version of OSeMOSYS. To get your code into the repository you'll have to submit it as a pull request rather than putting the code as an attachment to an issue. Once you've submitted a pull request it can be reviewed and accepted. This also allows us to credit everyone's contributions. Cheers, Taco..

Mattia-Allione commented 4 years ago

Hi Taco - Thanks for your advice, I'm new in Github so I didn't know the standard procedure. Cheers, Mattia