OSeMOSYS / OSeMOSYS_Pyomo

The Pyomo implementation of OSeMOSYS
Apache License 2.0
15 stars 15 forks source link

Correction of a few bugs #6

Closed ThomasHeggarty closed 4 years ago

ThomasHeggarty commented 4 years ago

The first couple of corrections were made for the code to match the problem description in the OSeMOSYS documentation. The last four corrections are pyomo syntax related issues.

willu47 commented 4 years ago

Hi @ThomasHeggarty - many thanks for these contributions. Could you clarify what the issues are that your pull request addresses? Best practice is to create an issue (as you have done) with are detailed explanation of the problem and the effects of it. You can then link to it from your pull request by using the hash symbol e.g. #1

ThomasHeggarty commented 4 years ago

Hi @willu47 - As requested, I have added a description of each issue in #5

willu47 commented 4 years ago

Perfect, super clear. Thanks so much! We’ll review and merge this in as soon as possible.