OSeMOSYS / osemosys_global

A global power system model generator for OSeMOSYS
https://osemosys-global.readthedocs.io/
GNU Affero General Public License v3.0
27 stars 14 forks source link

[BUG] Suriname run fails #167

Open tniet opened 6 months ago

tniet commented 6 months ago

Conda environment check

Current Behavior

Running Suriname (SUR) does not work for two related reasons:

  1. SUR does not have data from PLEXOS Global.
  2. Geographic filter finds RUSUR when searching for SUR in the files shown in the image below. image

Expected Behavior

Suriname model runs.

Steps To Reproduce

Set country to SUR and run the model.

Operating System

WSL on Windows 10.

Log output

No response

Anything else?

No response

maartenbrinkerink commented 6 months ago

Just some thoughts after a quick check;

  1. Besides SUR, we have more overlapping names. It's worth checking whether a model run with one of these countries (and vice versa with one of the regions) to see if the incorrect data is being pulled here as well. I suspect that we use e.g. .str.contains in parts of the workflow rather than == 'SUR' which can pull the incorrect entry.
  1. Besides SUR, there are other countries that are not included in the PLEXOS-World 2015 dataset but are included in the datasets with demand profiles and renewable timeseries.

-BLZ -TCD -HTI -MLT -SOM -SUR -TLS

  1. Given that in the next months we will start linking to the GEM datasets (through TZ) and will remove the links to the PLEXOS-World datasets, i'm not sure if it's worth the effort to try to go through the full workflow to try to tackle this. It might be easier to use the custom user inputs to load the required data for the time being.
maartenbrinkerink commented 6 months ago

Also, if we would want to change this in the workflow itself, it would also require adding a rule somewhere that if data for the specific country doesn't exist within the PLEXOS-World dataset that residual capacities etc. should be set to 0 for the first year.

maartenbrinkerink commented 1 month ago

This partly relates to #11 as well where the COG technology (co-generation) causes conflicts with the ISO3 for the Republic of Congo.