OSeMOSYS / osemosys_global

A global power system model generator for OSeMOSYS
https://osemosys-global.readthedocs.io/
GNU Affero General Public License v3.0
27 stars 17 forks source link

Tidy - closes #33 #36

Closed willu47 closed 3 years ago

willu47 commented 3 years ago
tniet commented 3 years ago

Hi @willu47 - thanks for the cleanup work! One question: You note "Ignore csv and text files in the repo". A bunch of the input data that is in the data directory is csv files, and the package isn't very useful without that. Before accepting this pull I want to check that this won't break the repo.

willu47 commented 3 years ago

Sorry, my comment was wasn't very clear. I added *.csv and *.txt to the .gitignore file. This will prevent new files of those types being accidentally tracked and committed. Existing files that are already tracked, such as the contents of the data folder will be unaffected.

You can also override the ignore using git add -f my file.txt

willu47 commented 3 years ago

@tniet I also notice many of the Jupyter notebooks are still present even though your pull request deleted them? Should they be removed?

tniet commented 3 years ago

I was ready to delete them (they will eventually all be removed) but @abhishek0208 suggested we wait a few days before doing so. They should be deleted once we’ve confirmed we haven’t missed anything in the scripts.