Datatypes of modes of operation seem to be different

OSeMOSYS / otoole

OSeMOSYS Tools for Energy

https://otoole.readthedocs.io

MIT License

23 stars 17 forks source link

Datatypes of modes of operation seem to be different #86

Closed willu47 closed 3 years ago

willu47 commented 3 years ago

[edited to clarify that issue is about mode of operation index datatype]

Input activity ratio mode of operation index is a float
Output activity ratio mode of operation index is an integer

HauHe commented 3 years ago

Do you want to say the OutputActivityRatio is always an integer? I would disagree on that. In my models for example transmission has the InputActivityRatio of 1 but the OutputActivityRatio is a float e.g. 0.95.

tniet commented 3 years ago

Hi @willu47 @HauHe - I would agree with @HauHe, both IAR and OAR should be float. Especially for CLEWs type analysis where OAR is used for rainfall and water balances it is definitely a float, but also in transmission situations as @HauHe states, co-generation and others.

abhishek0208 commented 3 years ago

@HauHe @tniet the issue is related to the 'mode' column/index for Input and OutputActivityRatios, not the value itself.