search

OStrama / weishaupt_modbus

This integration allows you to monitor and controll your weishaupt heatpump via modbus.
MIT License
21 stars 7 forks source link

Implimenation of an icon for the integration? #11

Closed exp1338 closed 1 month ago

exp1338 commented 1 month ago

Is your feature request related to a problem? Please describe. Implimenation of an icon for the integration?

Describe the solution you'd like Maybe a logo of Weishaupt is useable?

Describe alternatives you've considered Hopefully you can find a logo without any legal concern.

Additional context Screenshot 2024-10-19 195135

OStrama commented 1 month ago

I forked this from MadOne, where also no icon was included. It seems that HA or at least HACS finds and assigns the icon automatically. I try to find out how icons can be used..

MadOne commented 1 month ago

My Integration had an icon. I think it is missing because you changed the integration name. The icon was uploaded to the ha-brands repository like described in the hacs developer docs for integration.

MadOne commented 1 month ago

https://github.com/MadOne/ha-brands/commit/ef7a426e5f5e3d85b865b4738dad5d9fdc8f1ac0 needs to be merged into HA-Brands in case you like the icon and logos.

EDIT: Foldername was wrong: https://github.com/MadOne/ha-brands/commit/9db1bb2d82667e4e708346ea73a18aa276be0281

MadOne commented 1 month ago

@OStrama shall i start a pull request?

OStrama commented 1 month ago

Yes, that would be great!

MadOne commented 1 month ago

Fixed with https://github.com/OStrama/weishaupt_modbus/commit/92556c5ea590376fdedcf4ba51d69006494de441. Should be part of the next version.