search

OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

Allow for RedisCluster name different than the Release name #116

Closed sbocahu closed 11 months ago

sbocahu commented 1 year ago

Hi,

Could you please add a (optionnal) variable to allow setting a name for the RedisCluster different of the Release name ?

( https://github.com/OT-CONTAINER-KIT/helm-charts/blob/main/charts/redis-cluster/templates/redis-cluster.yaml#L5C28-L5C28 for example {{ .Values.RedisCluster.name | default(.Release.Name) }})

That way the chart can be used as a subchart while keeping a name such as "redis" whereas the release name is totally different

thanks

EStork09 commented 11 months ago

I have this problem also when combining the sentinel and replication charts, the resources will have the same name (different resources) but if used as a subchart with something it is useless.

I can make a PR for this and do something similar to what is suggested.

{{ .Values.name | default .Release.Name }}

And include this in all of the redis charts, is that something of value or should I just make my own charts?

shubham-cmyk commented 11 months ago

@EStork09 It sounds good you can open a PR regards this

EStork09 commented 11 months ago

@shubham-cmyk I am not 100% sure how you handle your version bumps and promotions, let me know if anything needs updated to align with your teams styling/naming/versioning