OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

[Feature]: Cert-Manager Dependency #133

Closed sadath-12 closed 1 year ago

sadath-12 commented 1 year ago

Added Cert-Manager Dependency and CRD for issue https://github.com/OT-CONTAINER-KIT/helm-charts/issues/129

sadath-12 commented 1 year ago

sure , what should be the default ?

sadath-12 commented 1 year ago

or how about adding a boolean value in values.yaml and conditioning the crd yaml

shubham-cmyk commented 1 year ago

sure , what should be the default ?

Make the default to be true

shubham-cmyk commented 1 year ago

or how about adding a boolean value in values.yaml and conditioning the crd yaml

Could work.

Add condition & add crd enable in values.yaml

sadath-12 commented 1 year ago

or how about adding a boolean value in values.yaml and conditioning the crd yaml

Could work.

Add condition & add crd enable in values.yaml

sure