search

OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

fix redis-sentinel selector role value #164

Closed whzghb closed 1 year ago

whzghb commented 1 year ago

fix redis-sentinel selector role value

whzghb commented 1 year ago

can you bump the version in the Chart.yaml

can you bump the version in the Chart.yaml

to 0.15.10?

shubham-cmyk commented 1 year ago

can you bump the version in the Chart.yaml

can you bump the version in the Chart.yaml

to 0.15.10?

yes but only for the sentinel>

Also it would be good if you sign off your commit.

shubham-cmyk commented 1 year ago 
To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin fix-redis-sentinel-selector-role-value

https://github.com/OT-CONTAINER-KIT/helm-charts/pull/164/checks?check_run_id=17724569386

whzghb commented 1 year ago

yes but only for the sentinel>

Also it would be good if you sign off your commit.

ok，i have resubmitted it