search

OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

Toleration specified in value file not applied for Operator #165

Open Jaryllan opened 1 year ago

Jaryllan commented 1 year ago

Does this issue reproduce with the latest release? Yes

What operating system and processor architecture are you using (kubectl version)? Client Version: v1.28.2 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.28.2

What did you do? helm upgrade redis-operator ot-helm/redis-operator --install --namespace ot-operators --values values-operator.yaml --create-namespace

values-operator.yaml content

tolerations:
  - effect: NoSchedule
    key: node-role.kubernetes.io/control-plane
    operator: Exists
nodeSelector:
  node-role.kubernetes.io/control-plane:

What did you expect to see? Toleration applied.

What did you see instead? Toleration not included.

Based on the value template. https://github.com/OT-CONTAINER-KIT/helm-charts/blob/main/charts/redis-operator/values.yaml. It was suppose to be supported to supply toleration, but upon installing the operator, the toleration is not included

artyom-p commented 1 year ago

Facing exactly the same issue now

mrhovunping commented 1 year ago

Facing also the same problem: operator-deployment.yaml is missing code to include tolerations defined in values.yml.

We should have a section like:

dpujadas commented 7 months ago

The problem with tolerations prevents us from using the chart. What else is needed to approve the PR and solve this issue?

lucasbrazi666 commented 6 months ago

Any news to solve this issue will be well appreciated! Thanks!

MFomichev commented 3 months ago

Any news about PR? We are looking forward to see it in upstream