search

OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

redis quote inside quote #170

Open amkartashov opened 10 months ago

amkartashov commented 10 months ago

https://github.com/OT-CONTAINER-KIT/helm-charts/blob/cfe2734d3f2894fd6c62b4143a5ac01855297e33/charts/redis/templates/redis-standalone.yaml#L18C1-L20

    redisSecret:
      name: "{{ .Values.redisStandalone.redisSecret.secretName | quote }}"
      key: "{{ .Values.redisStandalone.redisSecret.secretKey | quote }}"

rendering with below values

redisStandalone:
  redisSecret:
    secretName: redis-secret
    secretKey: password

will produce:

# Source: redis/templates/redis-standalone.yaml
...
    redisSecret:
      name: ""redis-secret""
      key: ""password""
shubham-cmyk commented 10 months ago

Thanks for reporting this. would you consider opening a PR ?

amkartashov commented 10 months ago

Thanks for reporting this. would you consider opening a PR ?

done