OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

redisConfig is not well generated #178

Open mrhovunping opened 9 months ago

mrhovunping commented 9 months ago

Does this issue reproduce with the latest release? Yes

What operating system and processor architecture are you using (kubectl version)?

kubectl version Output
$ kubectl version

Client Version: v1.28.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.21.9
WARNING: version difference between client (1.28) and server (1.21) exceeds the supported minor version skew of +/-1

What did you do?

Set values.yml with externalConfig Code
externalConfig:
  enabled: true
  data: |
    sentinel auth-pass myMaster xxxx

Helm with What did you expect to see?

  redisConfig:
    additionalRedisConfig: "config-ext-config"

What did you see instead?

    redisConfig:
      additionalRedisConfig: "config-ext-config"

Error come from : code

There is too much indent and element not well place

What did you expect to see?

  {{- if .Values.externalConfig.enabled }}
   redisConfig:
     additionalRedisConfig: "{{ .Values.redisSentinel.name | default .Release.Name }}-ext-config"
  {{- end }}

What did you see instead?

  {{- if .Values.externalConfig.enabled }}
    redisConfig:
      additionalRedisConfig: "{{ .Values.redisSentinel.name | default .Release.Name }}-ext-config"
  {{- end }}
shubham-cmyk commented 9 months ago

@mrhovunping Would you consider opening a PR for the same here