search

OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

[redis-operator] bug watch_namespace template #204

Closed vramperez closed 3 months ago

vramperez commented 4 months ago

Does this issue reproduce with the latest release? yes

What operating system and processor architecture are you using (kubectl version)? arch: x86_64 OS: Fedora 39

kubectl version Output
$ kubectl version
Client Version: v1.30.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.4-eks-036c24b

What did you do? helm template redis-operator charts/redis-operator --set redisOperator.watch_namespace=test

What did you expect to see?

...
        env:
        - name: ENABLE_WEBHOOKS
          value: "false"
        - name: WATCH_NAMESPACE
          value: test
...

What did you see instead? watch_namespace property is ignored:

...
        env:
        - name: ENABLE_WEBHOOKS
          value: "false"
...
Mortega5 commented 4 months ago

fixed in Rediss operator PR #990

vramperez commented 3 months ago

Fixed in https://github.com/OT-CONTAINER-KIT/redis-operator/commit/052d2e5e0d21b88ba6b9d5d4e9b31e51ae182a6d