OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

Using imagePullSecrets when using private registry #27

Closed mostafabayat closed 2 years ago

mostafabayat commented 2 years ago

We want to use redis operator in our cluster but we use private registry to use images. can you add imagePullSecrets to your templates?

rganeshsharma commented 2 years ago

@mostafabayat Can you try adding this :

redisOperator:
imagePullSecrets:
 - name: <secret>
mostafabayat commented 2 years ago

@mostafabayat Can you try adding this :

redisOperator:
imagePullSecrets:
 - name: <secret>

@rganeshsharma Thanks for your reply. but I mean using imagePullSecrets in redis standalone, not redisOperator itself. (and maybe in redis cluster, I didn't test)

rganeshsharma commented 2 years ago

@mostafabayat Sorry about that my bad. Yes we can use ImagePullSecrets in redis standalone and it pulls the Image successfully, but we may land up in livenessProbe and readinessProbe failures if yuo are using custom image through.

Also I am unable to use redis-cluster charts as it says "Fails to download charts" the repo is added

iamabhishek-dubey commented 2 years ago

This issues is fixed now.