OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

Support for setting LoadBalancerIP on redis standalone externalService #41

Closed chtombre closed 2 years ago

chtombre commented 2 years ago

I need to be able to specify loadBalancerIP when running externalService as type LoadBalancer.

Current version of helm template does not support that.

/helm-charts/blob/main/charts/redis/templates/service.yaml

chtombre commented 2 years ago

Oops, just figured that spec.LoadBalancerIP is planned to be deprecated. https://github.com/kubernetes/kubernetes/pull/107235

I needed this for running on om-premise k8s with metallb, but metallb supports setting loadBalancerIP with annotations, so that fixes my issue :-)