OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

PDB is misdefined for redis cluster #49

Closed ryan-dyer-sp closed 1 year ago

ryan-dyer-sp commented 1 year ago

When trying to create the default redis cluster configuration as mentioned here: https://ot-container-kit.github.io/redis-operator/guide/setup.html#redis-cluster Only the leaders get created as the operator is attempting to create a PDB with both maxUnavailable and minAvailable and failing

redis-operator-8488b858d6-5bchd redis-operator {"level":"error","ts":1666968931.3251204,"logger":"controller.rediscluster","msg":"Reconciler error","reconciler group":"redis.redis.opstreelabs.in","reconciler kind":"RedisCluster","name":"redis-cluster","namespace":"kong","error":"PodDisruptionBudget.policy \"redis-cluster-leader\" is invalid: spec: Invalid value: policy.PodDisruptionBudgetSpec{MinAvailable:(*intstr.IntOrString)(0xc00743b800), Selector:(*v1.LabelSelector)(0xc00743b820), MaxUnavailable:(*intstr.IntOrString)(0xc00743b840)}: minAvailable and maxUnavailable cannot be both set","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/int                                             ernal/controller/controller.go:227"}

Reference for only one of those two being allowed in a PDB: https://kubernetes.io/docs/tasks/run-application/configure-pdb/#specifying-a-poddisruptionbudget "You can specify only one of maxUnavailable and minAvailable in a single PodDisruptionBudget"