OT-CONTAINER-KIT / helm-charts

A repository which that will contain helm charts with best and security practices.
https://ot-container-kit.github.io/helm-charts
49 stars 84 forks source link

Add CRD TLS options to helm charts #68

Closed timvandruenen closed 1 year ago

timvandruenen commented 1 year ago

Hi, thanks for all the great work you're doing!

Is it a good idea to add the TLS options which are available in the CRD in the helm charts as well? TLS options in the CRD reference: https://ot-redis-operator.netlify.app/docs/crd-reference/redis-api/#tlsconfig

E.g. something like:

redisCluster:
  redisTLS:
    secretName: redis-tls-cert
    ca: ca.key
    cert: tls.crt
    key: tls.key

or

redisCluster:
  TLS:
    ca: ca.key
    cert: tls.crt
    key: tls.key
    secret:
      secretName: redis-tls-cert
shubham-cmyk commented 1 year ago

https://github.com/OT-CONTAINER-KIT/helm-charts/pull/72 Added!

timvandruenen commented 1 year ago

That's quick, thanks!