search

OT-CONTAINER-KIT / redis-operator

A golang based redis operator that will make/oversee Redis standalone/cluster/replication/sentinel mode setup on top of the Kubernetes.
https://ot-redis-operator.netlify.app/
Apache License 2.0
790 stars 217 forks source link

Add imagePullSecrets for initcontainers and sidecar #711

Open mrhovunping opened 10 months ago

mrhovunping commented 10 months ago

Is your feature request related to a problem? Please describe. I would like to sidecar a container to redis pod, the container is on a private repository, thus needs a cred to pull it. As I see there is no imagePullSecrets tag on initcontainers and sidecars on the redis-replication crd as well as redis-cluster, redis-standalone and redis-sentinel crds.

Describe the solution you'd like Add support of imagePullSecrets tag on initcontainers and sidecars

Describe alternatives you've considered As of now no quick solution as I am not the owner of the private repository.

What version of redis-operator are you using?

redis-operator version: 0.15.9

Additional context

shubham-cmyk commented 10 months ago

Thanks for using redis-operator we would add iamgepullSecret for the sidecars and init Containers

drivebyer commented 8 months ago

@mrhovunping As described in https://github.com/kubernetes/kubernetes/issues/82782#issuecomment-532202230, you can also use imagePullSecrets for initcontainers && sidecars.