OT-CONTAINER-KIT / redis-operator

A golang based redis operator that will make/oversee Redis standalone/cluster/replication/sentinel mode setup on top of the Kubernetes.
https://ot-redis-operator.netlify.app/
Apache License 2.0
734 stars 207 forks source link

The name and label role of the pod after master-slave switching are incorrect #882

Closed xiaozhuang-a closed 2 weeks ago

xiaozhuang-a commented 2 months ago

Describe your question

What version of redis-operator are you using?

redis-operator version:

Additional context

drivebyer commented 2 months ago

It needs to be fixed.

xiaozhuang-a commented 2 months ago

It needs to be fixed.

Do you have any solutions I understand. Can we solve this by not distinguishing between leaders and followers in STS ? or rather, what is the current pattern used to distinguish between leaders and followers

drivebyer commented 2 weeks ago

We can use the label key redis-role to distinguish between the master and slave, which is implemented by https://github.com/OT-CONTAINER-KIT/redis-operator/pull/925.

drivebyer commented 2 weeks ago

As said to the leader and follower words in the pod name, it's really hard to improve it because we need to use a different name to create a Redis cluster.