OT-CONTAINER-KIT / redis-operator

A golang based redis operator that will make/oversee Redis standalone/cluster/replication/sentinel mode setup on top of the Kubernetes.
https://ot-redis-operator.netlify.app/
Apache License 2.0
787 stars 216 forks source link

Unable to enable/disable AOF via redisConfig #906

Closed alita1991 closed 4 months ago

alita1991 commented 5 months ago

What version of redis operator are you using?

redis-operator version: 0.15.1

Does this issue reproduce with the latest release? Yes

What operating system and processor architecture are you using (kubectl version)?

kubectl version Output
Client Version: v1.29.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.26.12+k3s1
WARNING: version difference between client (1.29) and server (1.26) exceeds the supported minor version skew of +/-1

What did you do?

I created a Redis instance in standalone mode and I reconfigured the instance with additional config, to disable AOF persistence, which is required to restore from a backup.

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: redis-additional.conf
data:
  redis-additional.conf: |
    appendonly no

What did you expect to see?

127.0.0.1:6379> CONFIG GET appendonly
1) "appendonly"
2) "no"

What did you see instead?

127.0.0.1:6379> CONFIG GET appendonly
1) "appendonly"
2) "yes"

Additional context

I'm trying to restore from a backup a Redis instance, where mod = Standalone and another Redis cluster with Sentinel + Replication (3 replicas each).

asayles commented 4 months ago

Same issue with 0.15.1

drivebyer commented 4 months ago

It's fixed by https://github.com/OT-CONTAINER-KIT/redis/pull/7