OT-CONTAINER-KIT / redis-operator

A golang based redis operator that will make/oversee Redis standalone/cluster/replication/sentinel mode setup on top of the Kubernetes.
https://ot-redis-operator.netlify.app/
Apache License 2.0
731 stars 207 forks source link

fix: return ASAP after handling finalizer #940

Closed drivebyer closed 1 month ago

drivebyer commented 1 month ago

Description

Fixes #801

After we update the resource, we should return as soon as possible. Otherwise, we will get a conflict error when doing the next update.

Type of change

Checklist

Additional Context

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 38.96%. Comparing base (d121d86) to head (1e53480). Report is 52 commits behind head on master.

Files Patch % Lines
controllers/redis_controller.go 0.00% 3 Missing and 1 partial :warning:
controllers/rediscluster_controller.go 20.00% 3 Missing and 1 partial :warning:
controllers/redisreplication_controller.go 0.00% 3 Missing and 1 partial :warning:
controllers/redissentinel_controller.go 0.00% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #940 +/- ## ========================================== + Coverage 35.20% 38.96% +3.76% ========================================== Files 19 20 +1 Lines 3213 2728 -485 ========================================== - Hits 1131 1063 -68 + Misses 2015 1594 -421 - Partials 67 71 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.