OT-CONTAINER-KIT / redis-operator

A golang based redis operator that will make/oversee Redis standalone/cluster/replication/sentinel mode setup on top of the Kubernetes.
https://ot-redis-operator.netlify.app/
Apache License 2.0
731 stars 207 forks source link

Password appears decoded in operator logs in error "Could not execute command" #952

Closed Mlk777 closed 2 weeks ago

Mlk777 commented 1 month ago

Describe your question

Hi, we stumbled upon what we think is a problem when testing Redis resilience. The use case was to kill a pod to see what happens (follower for example) while monitoring the logs and check what was happening. The operator fails to do an action and we can see that the password is in clear is the msg "Could not execute command", cmd seems to be called in several places in the code but we didn't see the other info logs

What version of redis-operator are you using?

redis-operator version: v0.16.0

Additional context

password operator

Is it normal behavior or are we doing something wrong ?

Thanks in advance

drivebyer commented 2 weeks ago

It's a bit tricky to determine. Just as you mentioned, you terminated a pod. Once a pod is terminated, the cluster might require some time to bounce back. Therefore, this error log isn't significant. The key is to check if the final state is satisfactory or not.