search

OT-CONTAINER-KIT / redis-operator

A golang based redis operator that will make/oversee Redis standalone/cluster/replication/sentinel mode setup on top of the Kubernetes.
https://ot-redis-operator.netlify.app/
Apache License 2.0
731 stars 207 forks source link

PVCs aren't deleted during scale-in when keepAfterDelete is false #959

Open com6056 opened 1 month ago

com6056 commented 1 month ago

It seems that the PVCs aren't cleaned up when scaling-in the cluster (lowering the cluster size). It looks like right now the only time we handle PVC deletion is when the entire cluster is deleted: https://github.com/OT-CONTAINER-KIT/redis-operator/blob/master/controllers/rediscluster_controller.go#L58

drivebyer commented 1 month ago

It is indeed the issue: the PVC cleanup is managed by the custom resource finalizer now.