OT-CONTAINER-KIT / redis-operator

A golang based redis operator that will make/oversee Redis standalone/cluster/replication/sentinel mode setup on top of the Kubernetes.
https://ot-redis-operator.netlify.app/
Apache License 2.0
731 stars 206 forks source link

feat: add support for extra volume mounts for redis sentinel #994

Closed lsoica closed 1 week ago

lsoica commented 1 week ago

Description

Add the capability to mount extra volumes for the Redis Sentinel STS. One use case is the sentinel config file which is dynamically created at boot time so it needs write access to a file system.

Fixes #970

Type of change

Checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.78%. Comparing base (d121d86) to head (41cbb7c). Report is 75 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #994 +/- ## ========================================== + Coverage 35.20% 44.78% +9.58% ========================================== Files 19 20 +1 Lines 3213 2686 -527 ========================================== + Hits 1131 1203 +72 + Misses 2015 1413 -602 - Partials 67 70 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lsoica commented 1 week ago

@drivebyer could I have your review here please?

drivebyer commented 1 week ago

@drivebyer, could I have your review here, please?

@lsoica Sure, I will review this within today.