search

OT-CONTAINER-KIT / redis

A production optimized redis docker image
https://opstree.github.io
23 stars 51 forks source link

Lack of persistency in /node-conf path #34

Closed guychekarev closed 1 year ago

guychekarev commented 1 year ago

Hi, Starting from this change (7459d11) we have been facing issues with node configuration consistency. Followers failed to reconnect back to the cluster once their pod had been replaced. The followers couldn't find the node configuration since it did not persist after the restart. As a temporary fix we moved the /node-conf into /data, which fixed the issue since /data was a mounted volume.

Kind Regards, Guy

shubham-cmyk commented 1 year ago

I think this should not be the case since the object to add this was to make the pod more stable by moving the cluster configuration into a persistent volume.

Can you elaborate more this needs to be fixed. @guychekarev

guychekarev commented 1 year ago

@shubham-cmyk Thanks for your response. As I understand you were meaning to put /node-conf on a dedicated PVC, but in the Dockerfile the only volume was /data. https://github.com/OT-CONTAINER-KIT/redis/blob/f00884e30ed6e300f5161ea001ace631c24f19f7/Dockerfile#L50

shubham-cmyk commented 1 year ago

@guychekarev I just mounted the volume of the pod at location /node-conf to a PVC.
This could make the sure that node.conf is not lost but I am not sure on the container restart.

I think you can open a PR that could add another VOLUME["/node-conf"]

Let's see whether that could solve the problem