search

OTA-Insight / djangosaml2idp

SAML 2.0 Identity Provider in Django
Apache License 2.0
104 stars 96 forks source link

Add way to deal with missing expiration date #114

Closed nijel closed 3 years ago

nijel commented 3 years ago

This is a bug in SP, but it sems quite widespread, so allow way to handle this using configuration.

See #96

codecov-io commented 3 years ago

Codecov Report

Merging #114 (3487385) into master (e123199) will decrease coverage by 0.25%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   97.40%   97.15%   -0.26%     
==========================================
  Files           6        6              
  Lines         347      351       +4     
==========================================
+ Hits          338      341       +3     
- Misses          9       10       +1
Impacted Files Coverage Δ
djangosaml2idp/utils.py 98.11% <75.00%> (-1.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e123199...3487385. Read the comment docs.

mhindery commented 3 years ago

Thanks for the fix, I never did finish looking into the issue that you linked!