search

OTA-Insight / djangosaml2idp

SAML 2.0 Identity Provider in Django
Apache License 2.0
104 stars 96 forks source link

Fix case request is already signed #129

Open Amertz08 opened 3 years ago

Amertz08 commented 3 years ago

Fixes #121

Amertz08 commented 3 years ago

So what I did for now is comment out the fix. Modify the settings to actually sign the response. Then wrote a test to verify the 500. That test will fail w/ 500 since the code is commented out. You can uncomment the fix and see the test pass (i.e. fixes the bug). Issue I'm running into is inline modifying the IDP config for that test and that test only. Modifying the actual settings file vs. in the test via a fixture causes other tests to fail.

Amertz08 commented 3 years ago

So I am not running into any issues running the tests locally. Not sure what the issue in the build process is.

charron-tom commented 2 years ago

Can this PR be merged?