search

OTA-Insight / djangosaml2idp

SAML 2.0 Identity Provider in Django
Apache License 2.0
104 stars 96 forks source link

Refactor test fixtures #80

Closed Amertz08 closed 4 years ago

Amertz08 commented 4 years ago

This PR refactors common test code into pytest fixtures for easy of reuse.

Amertz08 commented 4 years ago

@mhindery you should be able to enable Travis CI checks on the repo so that no PRs can be merged unless they pass the Travis builds.

Amertz08 commented 4 years ago

Just doing a follow up on this.

mhindery commented 4 years ago

On the topic of Travis CI, I've requested this to someone from the team as I cannot enable this for the organisation myself. I'll also have a look at the Github actions, which offer free ci testing as well.

Amertz08 commented 4 years ago

Sounds good @mhindery. Also consider picking up a copy of TDD with Python. One of the best books on the subject for python. It's available for free online too. https://www.obeythetestinggoat.com/