search

OTAUpdateCenter / ota-update-centre

OTA Update Center - app part. Please visit our website for more information
https://www.otaupdatecenter.pro
Other
33 stars 43 forks source link

Update src/com/updater/ota/Config.java #1

Closed NilsP closed 12 years ago

NilsP commented 12 years ago

Just testing hard coded sdcard2 for download on vigor

jordancraig commented 12 years ago

Would rather this wasn't merged, using a hard coded path variable will cause issues with other devices. We will look into adding a configurable path in the next version, is there any reason the vigor needs a hard coded path?

jordancraig commented 12 years ago

Closing this for now, we'll add something to sort this for devices with a similar issue in the next release.

NilsP commented 12 years ago

No reason at all. Was just going to be a test to make sure sdcard2 worked for just the download to external card.

I actually plastered a comment all over to make sure it didn't get in

Thanks

----- Reply message ----- From: "Jordan Craig" notifications@github.com To: "OTAUpdateCenter/ota-update-centre" ota-update-centre@noreply.github.com Cc: "NilsP" nekberg@nycap.rr.com Subject: [ota-update-centre] Update src/com/updater/ota/Config.java (#1) Date: Tue, Aug 14, 2012 4:58 PM Would rather this wasn't merged, using a hard coded path variable will cause issues with other devices. We will look into adding a configurable path in the next version, is there any reason the vigor needs a hard coded path?

—

Reply to this email directly or view it on GitHub.

NilsP commented 12 years ago

I was going to close it when I got home anyway.

----- Reply message ----- From: "Jordan Craig" notifications@github.com To: "OTAUpdateCenter/ota-update-centre" ota-update-centre@noreply.github.com Cc: "NilsP" nekberg@nycap.rr.com Subject: [ota-update-centre] Update src/com/updater/ota/Config.java (#1) Date: Tue, Aug 14, 2012 5:37 PM Closing this for now, we'll add something to sort this for devices with a similar issue in the next release.

—

Reply to this email directly or view it on GitHub.

jordancraig commented 12 years ago

Yeah, I seen that comment a few minutes ago, thanks for bringing it to our attention though. Configurable download paths should have been something I added at the start.

NilsP commented 12 years ago

I guess you read the comments in the bug. What it really comes down to is that the internal is sdcard and the external is sdcard2 when the device is running and OTA puts the download to sdcard which is the internal. Under normal conditions that's fine but none of the Rezound/vigor recoveries support the internal. Recovery sees the external as sdcard so it never finds the zip on the external card. HTC's fault since they abandoned convention with the rezound and reversed them.

What I was trying to do was write the download to sdcard2 (external) and leave what is passed to recovery alone and see if it worked. I know when I manually copy the OTA-Updater folder, with the download in it, to the external card recovery sees it when OTA reboots to recovery to install.

If you want me to try it before you post it I will be happy to if you compile it for me since my local copile is not set up.

Thanks

Nils

---- Jordan Craig notifications@github.com wrote:

Yeah, I seen that comment a few minutes ago, thanks for bringing it to our attention though. Configurable download paths should have been something I added at the start.

Reply to this email directly or view it on GitHub: https://github.com/OTAUpdateCenter/ota-update-centre/pull/1#issuecomment-7741424

NilsP commented 12 years ago

I guess you read the comments in the bug. What it really comes down to is that the internal is sdcard and the external is sdcard2 when the device is running and OTA puts the download to sdcard which is the internal. Under normal conditions that's fine but none of the Rezound/vigor recoveries support the internal. Recovery sees the external as sdcard so it never finds the zip on the external card. HTC's fault since they abandoned convention with the rezound and reversed them.

What I was trying to do was write the download to sdcard2 (external) and leave what is passed to recovery alone and see if it worked. I know when I manually copy the OTA-Updater folder, with the download in it, to the external card recovery sees it when OTA reboots to recovery to install.

If you want me to try it before you post it I will be happy to if you compile it for me since my local copile is not set up.

Thanks

Nils ---- Jordan Craig notifications@github.com wrote:

Closing this for now, we'll add something to sort this for devices with a similar issue in the next release.

Reply to this email directly or view it on GitHub: https://github.com/OTAUpdateCenter/ota-update-centre/pull/1#issuecomment-7741248