OTRF / ThreatHunter-Playbook

A community-driven, open-source project to share detection logic, adversary tradecraft and resources to make detection development more efficient.
MIT License
3.97k stars 803 forks source link

Update Markdown Tables on Notebooks #54

Closed Cyb3rWard0g closed 2 years ago

Cyb3rWard0g commented 2 years ago

https://github.com/executablebooks/MyST-Parser/issues/430

Cyb3rWard0g commented 2 years ago

Current version: myst-parser==0.15.2

Cyb3rWard0g commented 2 years ago

Updated to version: myst-parser==0.17.0 and I did not get the same error:

in render_table assert token.children and len(token.children) > 1 AssertionError

Cyb3rWard0g commented 2 years ago

Another error myst-nb 0.13.2 requires myst-parser~=0.15.2, but you have myst-parser 0.17.0 which is incompatible

Cyb3rWard0g commented 2 years ago

With updated myst-parser I now get the following error:

  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\myst_parser\main.py", line 235, in default_parser
    raise NotImplementedError(
NotImplementedError: default_parser has been deprecated and replaced by create_md_parser.You must also supply the renderer class directly to create_md_parser.
Cyb3rWard0g commented 2 years ago

I had to revert to

myst-nb 0.13.2 requires myst-parser~=0.15.2

and simply removed empty tables